adds digital sensor interface #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maxx Wilson <[email protected]>
Co-authored-by: Maxx Wilson <[email protected]>
xwilson03
commented
Nov 17, 2024
01_Libraries/ghost_v5_interfaces/test/config/example_robot.yaml
Outdated
Show resolved
Hide resolved
01_Libraries/ghost_v5_interfaces/test/config/example_robot_2.yaml
Outdated
Show resolved
Hide resolved
01_Libraries/ghost_v5_interfaces/test/config/test_load_digital_device_config.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This should not be commented out.
...braries/ghost_v5_interfaces/include/ghost_v5_interfaces/util/device_config_factory_utils.hpp
Outdated
Show resolved
Hide resolved
xwilson03
commented
Nov 18, 2024
There was a problem hiding this comment.
Should this be digital_outputs instead?
There was a problem hiding this comment.
Should this be digital_inputs instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Link: Link
Issue Link: Link
Description
Add hardware interface support for digital sensors plugged into ADI ports.
Reviewers
Changelog
Reviewer Guide
11_Robots/ghost_over_under/config/robot_hardware_config_worlds_24.yaml)
Testing
Automatic
Manual